Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test best practice #5473

Merged
merged 2 commits into from
May 9, 2024
Merged

Unit test best practice #5473

merged 2 commits into from
May 9, 2024

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented May 8, 2024

What are you changing in this pull request and why?

Closes #5439

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@matthewshaver matthewshaver requested a review from a team as a code owner May 8, 2024 22:47
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 11:55pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. labels May 8, 2024
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! approving with one small sugg

website/docs/docs/build/unit-tests.md Outdated Show resolved Hide resolved
@matthewshaver matthewshaver merged commit 814a992 into current May 9, 2024
11 checks passed
@matthewshaver matthewshaver deleted the unittest branch May 9, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs on best practice to only run unit tests in dev and CI and exclude them from prod
2 participants