Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated functionality for v1.8 #5475

Merged
merged 3 commits into from
May 9, 2024
Merged

Deprecated functionality for v1.8 #5475

merged 3 commits into from
May 9, 2024

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented May 8, 2024

What are you changing in this pull request and why?

Closes #5320

Backported to v1.7 and v1.6

Checklist

@matthewshaver matthewshaver requested a review from a team as a code owner May 8, 2024 23:08
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 0:13am

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels May 8, 2024
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! approving with just one sugg to consider

{% materialization view, default %}
{{ return(my_cool_package.materialization_view_default()) }}
{% endmaterialization %}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if this "deprecation notice" is worth capturing in a snippet/partial/reusable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only going in the migration guides. When we actually deprecate it in 1.9 I'll see how extensive it is. Snippet might be a good call then.

@matthewshaver matthewshaver enabled auto-merge May 9, 2024 00:00
@matthewshaver matthewshaver merged commit 2a0eb8a into current May 9, 2024
11 checks passed
@matthewshaver matthewshaver deleted the package-override branch May 9, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs Changes Needed from dbt-core Issue #9981
2 participants