update scd docs per feedback #5754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
mirnawong1
commented
Jul 9, 2024
| @@ -45,8 +45,8 @@ semantic_models: | |||
| description: A record for every transaction that takes place. Carts are considered multiple transactions for each SKU. | |||
| model: {{ ref("fact_transactions") }} | |||
| defaults: | |||
| agg_time_dimension: metric_time | |||
| # --- entities --- | |||
| agg_time_dimension: metric_time | |||
There was a problem hiding this comment.
should this be metric_time?
There was a problem hiding this comment.
No it should be 'order_date'
Jstein77
approved these changes
Jul 9, 2024
mirnawong1
commented
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened this pr to address the feedback from issue #5395. It also adds info regarding validity_params and how it relates to the scd table columns: valid_to/valid_from.
[ ] Outstanding question wrt metric_time
[ ] PM review needd
Resolves #5395