Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update explorer content and imgs #5773

Merged
merged 18 commits into from
Jul 16, 2024
Merged

Conversation

mirnawong1
Copy link
Contributor

this pr removes outdated icons and updates some language, as well as adds updated gifs/imgs

raised in slack thread: https://dbt-labs.slack.com/archives/C01Q230T0E8/p1720547588445529

@mirnawong1 mirnawong1 requested a review from a team as a code owner July 11, 2024 10:50
Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 3:38pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Jul 11, 2024
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thank you so much for these updates. left some minor suggs

website/docs/docs/collaborate/explore-multiple-projects.md Outdated Show resolved Hide resolved
website/docs/docs/collaborate/explore-multiple-projects.md Outdated Show resolved Hide resolved
website/docs/docs/collaborate/explore-multiple-projects.md Outdated Show resolved Hide resolved

<Lightbox src="/img/docs/collaborate/dbt-explorer/cross-project-lineage-parent.png" width="70%" height="100" title="Cross-project lineage in a parent project"/>
<Lightbox src="/img/docs/collaborate/dbt-explorer/cross-project-lineage-parent.png" width="100%" height="100" title="View your cross-project lineage in a parent project and the other projects that reference it by clicking the 'Relationships' tab."/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Lightbox src="/img/docs/collaborate/dbt-explorer/cross-project-lineage-parent.png" width="100%" height="100" title="View your cross-project lineage in a parent project and the other projects that reference it by clicking the 'Relationships' tab."/>
<Lightbox src="/img/docs/collaborate/dbt-explorer/cross-project-lineage-parent.png" width="100%" height="100" title="View your cross-project lineage in a parent project and the other projects that reference it by clicking the "Relationships" tab."/>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the build is failing bc of the quotes. i think this is why i iniitally use apostrophes in the captions. going to go back to apostrophe's

website/docs/docs/collaborate/explore-multiple-projects.md Outdated Show resolved Hide resolved
website/docs/docs/collaborate/explore-multiple-projects.md Outdated Show resolved Hide resolved
To get a list view of all the projects in your account:
- Navigate to the top left section of the **Explore** page, near the navigation bar.
- Hover over the project name and select the account name.
- This will return a project view page, allowing you to see all the projects in the account. It returns a public model list, project list, and a search bar for project searches.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what "this" is referring to here in this bullet. sugg improving for clarity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it to:

< - Hover over the project name and select the account name to return a project view page, allowing you to see all the projects in the account.

website/docs/docs/collaborate/explore-multiple-projects.md Outdated Show resolved Hide resolved
To get a list view of all the projects in your account:
- Navigate to the top left section of the **Explore** page, near the navigation bar.
- Hover over the project name and select the account name to return a project view page, allowing you to see all the projects in the account.
- It returns a public model list, project list, and a search bar for project searches.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to before, not sure what "it" is referring to here:

"To get a list view of all the projects in your account, it returns a public model list, project list, and a search bar for project searches"

maybe the "original sentence" just needed to be indented for an L2 bullet list (instead of L1)

Copy link
Contributor Author

@mirnawong1 mirnawong1 Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok got it! updated to the below.

To get a list view of all the projects in your account:

  • Navigate to the top left section of the Explore page, near the navigation bar.
  • Hover over the project name and select the account name. This takes you to a project view page, where you can view all the projects in the account.
  • Click the List view icon in the page's upper right corner to see a list view of all the projects in the account.
  • The list view page displays a public model list, project list, and a search bar for project searches.
  • Click the Lineage view icon in the page's upper right corner to view the project-level lineage gra

@nghi-ly nghi-ly enabled auto-merge (squash) July 16, 2024 15:34
@nghi-ly nghi-ly merged commit b2cd567 into current Jul 16, 2024
10 checks passed
@nghi-ly nghi-ly deleted the update-explorer-multi-project branch July 16, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants