Update oracle adapter docs #5798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
ramapemmaraju
approved these changes
Jul 17, 2024
mirnawong1
reviewed
Jul 24, 2024
mirnawong1
reviewed
Jul 24, 2024
github-actions
bot
added
size: large
mirnawong1
reviewed
Jul 24, 2024
|
|
||
| ## Python Models using Oracle Autonomous Database (ADB-S) | ||
| ## Python models using Oracle Autonomous Database (ADB-S) |
There was a problem hiding this comment.
hey @aosingh , thanks so much for opening this up and looks great! this section here is wrapped in a version block. since we only have v1.5 and higher on the docs site now, we can remove the versionblock now since it applies to all. wanted to get your thoughts on that?
There was a problem hiding this comment.
Sure, we can remove the version block. It makes sense
There was a problem hiding this comment.
Let me remove the version block and update the PR
There was a problem hiding this comment.
great stuff! removed the versionblocks for you @aosingh !
|
Thanks @mirnawong1 for reviewing the docs and fixing the typos. This looks good. |
mirnawong1
reviewed
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
This PR updates oracle adapter docs:
condaenvironment manager for dbt Python modelsChecklist