Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new role for marketplace apps #5815

Merged
merged 9 commits into from
Jul 23, 2024
Merged

Adding a new role for marketplace apps #5815

merged 9 commits into from
Jul 23, 2024

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Adds the new marketplace app permission and role to the enterprise table
Adds the role as assignable to service tokens
Adds the role as a pre-requisite for the Snowflake Native App

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@matthewshaver matthewshaver requested a review from a team as a code owner July 19, 2024 19:39
Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jul 23, 2024 9:06pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Jul 19, 2024
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshaver This looks great! Just one question.

@@ -28,7 +28,7 @@ The following are the prerequisites for dbt Cloud and Snowflake.

- You must have a dbt Cloud account on the Enterprise plan that's in an AWS Region or Azure region. If you don't already have one, please [contact us](mailto:[email protected]) to get started.
- Currently, Semantic Layer is unavailable for Azure ST instances and the **Ask dbt** chatbot will not function in the dbt Snowflake Native App without it.
- Your dbt Cloud account must have permission to create a [service token](/docs/dbt-cloud-apis/service-tokens). For details, refer to [Enterprise permissions](/docs/cloud/manage-access/enterprise-permissions).
- Your dbt Cloud account must have permission to create a [service token](/docs/dbt-cloud-apis/service-tokens) assigned the `Manage marketplace apps` role. For details, refer to [Enterprise permissions](/docs/cloud/manage-access/enterprise-permissions).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lower down on this page, we also say to grant Job Admin, Metadata, Semantic Layer Only. IS there a reason we're just mentioning this one or should we mention these as well?

https://github.com/dbt-labs/docs.getdbt.com/pull/5815/files#diff-770944d95df777c9ab980c64ab039e22058f83e3eaa322e78fca7429f397c128L71-L73

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good catch. That shouldn't be in that spot, reverting it to the way it was and relying on the below info only!

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small suggesiton!

@matthewshaver matthewshaver enabled auto-merge (squash) July 23, 2024 20:53
@matthewshaver matthewshaver merged commit d0a35ed into current Jul 23, 2024
10 checks passed
@matthewshaver matthewshaver deleted the new-role branch July 23, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants