New behavior with limit parameter #5832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
nghi-ly
commented
Jul 23, 2024
nghi-ly
commented
Jul 24, 2024
joellabes
approved these changes
Jul 24, 2024
| @@ -19,6 +19,8 @@ Release notes are grouped by month for both multi-tenant and virtual private clo | |||
| [^*] The official release date for this new format of release notes is May 15th, 2024. Historical release notes for prior dates may not reflect all available features released earlier this year or their tenancy availability. | |||
|
|
|||
| ## July 2024 | |||
| - **Behavior change:** dbt Cloud IDE attaches a `--limit 100` to queries by default to avoid slow and expensive queries from running in the development environment. Recently, dbt Core has changed how the `limit` is applied to ensure that `order by` clauses are consistently respected. Because of this, queries that already contain a limit clause might now cause errors in the IDE previews. An option to prevent the limit from being applied will become available to the dbt Cloud IDE later this year. Until this is released, dbt Labs strongly recommends removing the (duplicate) limit clause from your queries when previewing them. | |||
There was a problem hiding this comment.
Suggested change
| - **Behavior change:** dbt Cloud IDE attaches a `--limit 100` to queries by default to avoid slow and expensive queries from running in the development environment. Recently, dbt Core has changed how the `limit` is applied to ensure that `order by` clauses are consistently respected. Because of this, queries that already contain a limit clause might now cause errors in the IDE previews. An option to prevent the limit from being applied will become available to the dbt Cloud IDE later this year. Until this is released, dbt Labs strongly recommends removing the (duplicate) limit clause from your queries when previewing them. | |
| - **Behavior change:** dbt Cloud IDE attaches a `--limit 100` to preview queries by default to avoid slow and expensive queries from running in the development environment. Recently, dbt Core has changed how the `limit` is applied to ensure that `order by` clauses are consistently respected. Because of this, queries that already contain a limit clause might now cause errors in the IDE previews. An option to prevent the limit from being applied will become available to the dbt Cloud IDE later. Until this is released, dbt Labs recommends removing the (duplicate) limit clause from your queries when previewing them. |
"later this year" sounds a long time away, but this should be pretty soon 🤞
I wouldn't say we have to strongly recommend it - if you don't it just won't work. Feels like we only have to be that wemphatic when you might be about to do something possible but ill-advised
mirnawong1
reviewed
Jul 24, 2024
mirnawong1
approved these changes
Jul 24, 2024
Co-authored-by: Mirna Wong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Add release note that informs users about new behavior with
limitargument in SQL queriesChecklist