Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update adapter-creation.md #5853

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Update adapter-creation.md #5853

merged 4 commits into from
Jul 29, 2024

Conversation

amychen1776
Copy link
Collaborator

What are you changing in this pull request and why?

Update the trusted adapter docs to align with the new semantic versioning

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@amychen1776 amychen1776 requested a review from a team as a code owner July 29, 2024 11:59
@vercel Vercel
Copy link

vercel bot commented Jul 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jul 29, 2024 0:31am

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix. labels Jul 29, 2024
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Jul 29, 2024
mirnawong1
mirnawong1 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome and small tweak as a suggestion. added link to the upgrade guide too.

@amychen1776 amychen1776 enabled auto-merge July 29, 2024 12:22
@amychen1776 amychen1776 merged commit 0165316 into current Jul 29, 2024
10 checks passed
@amychen1776 amychen1776 deleted the amychen1776-patch-1 branch July 29, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content guides Knowledge best suited for Guides size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amychen1776 @mirnawong1