-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add athena adapter preview #5858
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@matthewshaver I think you're missing something on the sidebar because I can't see Athena on it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me outside of the comments I made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to Amy's comments, but this looks good to me otherwise!
Changing to beta
website/docs/docs/cloud/connect-data-platform/about-connections.md
Outdated
Show resolved
Hide resolved
Removing as it's beta
@@ -8,6 +8,7 @@ pagination_prev: null | |||
--- | |||
dbt Cloud can connect with a variety of data platform providers including: | |||
- [AlloyDB](/docs/cloud/connect-data-platform/connect-redshift-postgresql-alloydb) | |||
- [Amazon Athena (Beta)](/docs/cloud/connect-data-platform/connect-amazon-athena) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qq - is it preview or beta?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the beta
website/docs/docs/cloud/connect-data-platform/connect-amazon-athena.md
Outdated
Show resolved
Hide resolved
website/docs/docs/cloud/connect-data-platform/connect-amazon-athena.md
Outdated
Show resolved
Hide resolved
|
||
Your environment(s) must be on ["Keep on latest version"](/docs/dbt-versions/versionless-cloud) to use the Amazon Athena connection. | ||
|
||
Connect dbt Cloud to Amazon's Athena interactive query service to build your dbt Project. The following are the required and optional fields for configuring the Athena connection: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where should users add this field? maybe a screenshot would be helpful?
hey Matt, looks great and added some comments. there's no release note for this - should there be? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
…thena.md Co-authored-by: Mirna Wong <[email protected]>
…thena.md Co-authored-by: Mirna Wong <[email protected]>
What are you changing in this pull request and why?
Adds Amazon Athena adapter configuration page for dbt Cloud (in Preview)
Updates list of available dbt Cloud connections
Adds a release note for the Preview
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.js
website/vercel.json
npm run build
to update the links that point to deleted pages