Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add athena adapter preview #5858

Merged
merged 12 commits into from
Aug 2, 2024
Merged

Add athena adapter preview #5858

merged 12 commits into from
Aug 2, 2024

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Adds Amazon Athena adapter configuration page for dbt Cloud (in Preview)
Updates list of available dbt Cloud connections
Adds a release note for the Preview

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@matthewshaver matthewshaver requested a review from a team as a code owner July 29, 2024 20:54
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Aug 2, 2024 4:27pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Jul 29, 2024
@amychen1776
Copy link
Collaborator

@matthewshaver I think you're missing something on the sidebar because I can't see Athena on it
image

Copy link
Collaborator

@amychen1776 amychen1776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me outside of the comments I made

Copy link

@jenniferjsmmiller jenniferjsmmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Amy's comments, but this looks good to me otherwise!

@@ -8,6 +8,7 @@ pagination_prev: null
---
dbt Cloud can connect with a variety of data platform providers including:
- [AlloyDB](/docs/cloud/connect-data-platform/connect-redshift-postgresql-alloydb)
- [Amazon Athena (Beta)](/docs/cloud/connect-data-platform/connect-amazon-athena)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq - is it preview or beta?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the beta


Your environment(s) must be on ["Keep on latest version"](/docs/dbt-versions/versionless-cloud) to use the Amazon Athena connection.

Connect dbt Cloud to Amazon's Athena interactive query service to build your dbt Project. The following are the required and optional fields for configuring the Athena connection:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where should users add this field? maybe a screenshot would be helpful?

@mirnawong1
Copy link
Contributor

hey Matt, looks great and added some comments. there's no release note for this - should there be?

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@matthewshaver matthewshaver enabled auto-merge (squash) August 2, 2024 16:15
@matthewshaver matthewshaver merged commit 43a10d1 into current Aug 2, 2024
10 checks passed
@matthewshaver matthewshaver deleted the athena-preview branch August 2, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants