Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snowflake-configs.md #5862

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Update snowflake-configs.md #5862

merged 6 commits into from
Jul 30, 2024

Conversation

amychen1776
Copy link
Collaborator

What are you changing in this pull request and why?

Resolving Issue #4869

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@amychen1776 amychen1776 requested review from dataders and a team as code owners July 30, 2024 14:18
Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jul 30, 2024 5:21pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jul 30, 2024
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @amychen1776

Thanks for flagging this - this was really good. I'll approve this for you.
As a non-blocker suggestion, would it be worthwhile linking to the Model Contracts page and the Copy Grants config section?

Kind Regards

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @amychen1776

The changes are great! Thanks for that. I've approved this for you and will merge this for you.

Kind Regards
Natalie

@nataliefiann nataliefiann merged commit db7cbb8 into current Jul 30, 2024
10 checks passed
@nataliefiann nataliefiann deleted the amychen1776-patch-1 branch July 30, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants