Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Firebolt features and connection parameters #5868

Merged

Conversation

ptiurin
Copy link
Contributor

@ptiurin ptiurin commented Jul 31, 2024

What are you changing in this pull request and why?

Firebolt has rolled out a new authentication method with service account credentials, all new Firebolt DBT users would use it from now on. Existing dbt-firebolt connector handles this behind the scenes allowing users that haven't migrated yet to use their old credentials while also allowing new customers to use the recommended way of authentication. This change in documentation reflects the new auth to avoid confusion for the new users.

Also updating some of the outdated information on Firebolt features supported, like removal of Join indexes and engine types and updating doc links to the new website.

Checklist

Adding or removing pages (delete if not applicable):

  • Run link testing locally with npm run build to update the links that point to deleted pages

@ptiurin ptiurin requested review from dataders and a team as code owners July 31, 2024 13:24
Copy link

welcome bot commented Jul 31, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jul 31, 2024 1:31pm

@runleonarun runleonarun added the new contributor Label for first-time contributors label Jul 31, 2024
@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Jul 31, 2024


#### Example of a Dimension Table With a Join Index
## How Aggregating Indexes Are Named
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## How Aggregating Indexes Are Named
## How aggregating indexes are named

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for opening this up @ptiurin , will get this merged for you!

@mirnawong1
Copy link
Contributor

hey @ptiurin , thanks for opening this pr! I'm trying to update this branch but i don't have permissions. any chance you can update the branch on your end before i merge?

@mirnawong1 mirnawong1 merged commit 966ad09 into dbt-labs:current Aug 7, 2024
10 of 11 checks passed
@ptiurin
Copy link
Contributor Author

ptiurin commented Aug 8, 2024

Hi @mirnawong1 , sorry I was OOO so didn't catch your comment in time. Thanks for merging this PR! Do you want me to create another with the changes proposed here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants