Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty FAQ in snapshots page #5880

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

Victoriapm
Copy link
Contributor

@Victoriapm Victoriapm commented Aug 2, 2024

What are you changing in this pull request and why?

There is an empty FAQ in this page . I can't find the FAQ file it's referencing, that's why I'm deleting it to fix.

image

Checklist

@Victoriapm Victoriapm requested a review from a team as a code owner August 2, 2024 09:18
Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Aug 2, 2024 9:32am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Aug 2, 2024
@mirnawong1
Copy link
Contributor

great catch, thank you @Victoriapm ! i'l have a look too and i think this is also referenced here: https://docs.getdbt.com/reference/resource-configs/target_schema#faqs so will remove too

faq was rmoved so removing this path
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you again for opening @Victoriapm ! approving and merging for you!

@mirnawong1 mirnawong1 enabled auto-merge (squash) August 2, 2024 09:26
@mirnawong1 mirnawong1 merged commit 8994f8b into current Aug 2, 2024
10 checks passed
@mirnawong1 mirnawong1 deleted the fix/remove-empty-FAQ branch August 2, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants