Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure private link #5929

Merged
merged 16 commits into from
Aug 13, 2024
Merged

Azure private link #5929

merged 16 commits into from
Aug 13, 2024

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Enhances the Snowflake instruction for Azure
Add Databricks instructions

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@matthewshaver matthewshaver requested a review from a team as a code owner August 13, 2024 21:17
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com 🛑 Canceled (Inspect) Aug 13, 2024 11:46pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Aug 13, 2024
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! left some minor suggs

website/docs/docs/cloud/secure/databricks-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/databricks-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/databricks-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/snowflake-privatelink.md Outdated Show resolved Hide resolved
- Provide them with your dbt Cloud account ID along with any other information requested in the article.
- AWS account ID: `346425330055` - _NOTE: This account ID only applies to dbt Cloud Multi-Tenant environments. For Virtual Private/Single-Tenant account IDs please contact [Support](https://docs.getdbt.com/community/resources/getting-help#dbt-cloud-support)._
- **AWS account ID**: `346425330055` — _NOTE: This account ID only applies to AWS dbt Cloud multi-tenant environments. For AWS Virtual Private/Single-Tenant account IDs please contact [Support](https://docs.getdbt.com/community/resources/getting-help#dbt-cloud-support)._
- **Azure private endpoint resource ID**: Please contact [Support](https://docs.getdbt.com/community/resources/getting-help#dbt-cloud-support).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Azure private endpoint resource ID**: Please contact [Support](https://docs.getdbt.com/community/resources/getting-help#dbt-cloud-support).
- **Azure private endpoint resource ID**: Please contact [support](https://docs.getdbt.com/community/resources/getting-help#dbt-cloud-support) for this ID.

website/docs/docs/cloud/secure/snowflake-privatelink.md Outdated Show resolved Hide resolved
Changing support links
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-reviewed for you, @matthewshaver ! minor nits

website/docs/docs/cloud/secure/databricks-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/databricks-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/snowflake-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/snowflake-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/snowflake-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/snowflake-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/snowflake-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/snowflake-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/snowflake-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/snowflake-privatelink.md Outdated Show resolved Hide resolved
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@matthewshaver matthewshaver enabled auto-merge (squash) August 13, 2024 23:40
@matthewshaver matthewshaver merged commit 58a6473 into current Aug 13, 2024
10 checks passed
@matthewshaver matthewshaver deleted the privatelink branch August 13, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants