Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new MF command #5930

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Adding new MF command #5930

merged 5 commits into from
Aug 14, 2024

Conversation

runleonarun
Copy link
Collaborator

@runleonarun runleonarun commented Aug 14, 2024 •
edited
Loading

What are you changing in this pull request and why?

Adds new mf validate-config command. Originally added previously but removed here

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@runleonarun runleonarun requested a review from a team as a code owner August 14, 2024 00:29
@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Aug 14, 2024 0:55am

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs and removed size: small This change will take 1 to 2 days to address labels Aug 14, 2024
@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Aug 14, 2024
@runleonarun runleonarun changed the title adding new MF command Adding new MF command Aug 14, 2024
@runleonarun
Copy link
Collaborator Author

@WilliamDee Fixed those spots and the link. Ready for re-review when you have a chance.

WilliamDee
WilliamDee approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@WilliamDee WilliamDee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

nataliefiann
nataliefiann approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @runleonarun

Great PR! Thanks for flagging this. No suggestions or recommendations from me. I've approved this for you. Please let me know if there's anything else I can do to help with this.

Kind Regards
Natalie

@runleonarun runleonarun merged commit 9a09eb9 into current Aug 14, 2024
10 checks passed
@runleonarun runleonarun deleted the new-validate branch August 14, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliefiann nataliefiann nataliefiann approved these changes

@WilliamDee WilliamDee WilliamDee approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@runleonarun @WilliamDee @nataliefiann