Vale: test with several files #5934
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
There was a problem hiding this comment.
this test with many edited files is a bit interesting, @mirnawong1 .
- Vale didn't flag anything on 2 (out of 3) files. i expected for some lines to be flagged. i wonder if this has something to do with "reviewdog" erroring out.
- Vale flagged several lines in the 3rd file but there were some false positives.
|
❗️Oh no, some Vale linting found issues! Please check the Files change tab for detailed results and make the necessary updates. ➡️ Link to detailed report: Files changed |
There was a problem hiding this comment.
@mirnawong1 : fantastic work on integrating Vale! left some thoughts/questions for ya
happy to further discuss any of my comments or any questions you may have
|
|
||
| <!-- truncate --> | ||
| Since the early days of dbt, folks have been interested having MSFT data platforms. Huge shoutout to [Mikael Ene](https://github.com/mikaelene) and [Jacob Mastel](https://github.com/jacobm001) for their efforts back in 2019 on the original SQL Server adapters ([dbt-sqlserver](https://github.com/dbt-msft/dbt-sqlserver) and [dbt-mssql](https://github.com/jacobm001/dbt-mssql), respectively) |
There was a problem hiding this comment.
looking at the typo warnings below. curious if there's an easy way to make this list shorter. totally non-blocking.
is it easy for any tech writer to add to our custom dictionary? just wondering whether it's a good idea for each person to be responsible for it 🤔
|
|
||
| Many data teams currently use Azure Synapse dedicated pools. However, Fabric Synapse Data Warehouse is the future of data warehousing in the Microsoft Ecosystem. Azure Synapse Analytics will remain available for a few more years, but Microsoft’s main focus is on Fabric as we can see in their roadmap and launches. | ||
|
|
||
| Because data platform migrations are complex and time-consuming, it’s perfectly reasonable to still be using dbt with Azure Synapse for the next two years while the migration is under way. Thankfully, if your team already is using ASADSP, transitioning to the new Cloud offering will be much more straightforward than the migration from on-premise databases to the Cloud. |
There was a problem hiding this comment.
curious, i wonder if there are more false positives when linting words that are acronyms.
wonder if it would be better -- and if it's easy to do -- to just ignore acronyms.
|
|
||
| :::tip | ||
| 💁🏻♀️ If your BI tool allows it, make sure to do the BI-related steps above **in a development environment**. If it doesn’t have these capabilities, stick with duplicating the data product you’re re-building and perform this there so you can swap it later after you’ve tested it thoroughly. | ||
| However, if you must use ADF as the deployment pipeline, it is possible to use dbt Cloud APIs. Running dbt Core within Azure Data Factory can be challenging as there’s no easy way to install and invoke dbt Core, because there’s no easy way to install and run Python. The workarounds aren’t great, for example: Setting up dbt calls via Azure Serverless Functions and invoking them from ADF. |
There was a problem hiding this comment.
maybe we can add "APIs" in our custom dictionary?
There was a problem hiding this comment.
i noticed that "... invoking them from ADF" has an extra space btn them and from.
is this something Vale can check and flag? hmm, though it may pick up more false positives 🤔
| <Lightbox src="/img/snowflake_tutorial/dbt_cloud_setup_snowflake_connection_start.png" title="dbt Cloud - Choose Snowflake Connection" /> | ||
|
|
||
| 4. Enter your **Settings** for Snowflake with: | ||
| * **Account** — Find your account by using the Snowflake trial account URL and removing `snowflakecomputing.com`. The order of your account information will vary by Snowflake version. For example, Snowflake's Classic console URL might look like: `oq65696.west-us-2.azure.snowflakecomputing.com`. The AppUI or Snowsight URL might look more like: `snowflakecomputing.com/west-us-2.azure/oq65696`. In both examples, your account will be: `oq65696.west-us-2.azure`. For more information, see [Account Identifiers](https://docs.snowflake.com/en/user-guide/admin-account-identifier.html) in the Snowflake docs. |
There was a problem hiding this comment.
Snowflake should probably be in our custom dictionary, i think
|
|
||
| ## Controlling table expiration | ||
|
|
||
| By default, dbt-created tables never expire. You can configure certain model(s) |
There was a problem hiding this comment.
hmm, not sure why Vale is flagging this as a typo
|
❗️Oh no, some Vale linting found issues! Please check the Files change tab for detailed results and make the necessary updates. ➡️ Link to detailed report: Files changed |
|
❗️Oh no, some Vale linting found issues! Please check the Files change tab for detailed results and make the necessary updates. ➡️ Link to detailed report: Files changed |
|
❗️Oh no, some Vale linting found issues! Please check the Files change tab for detailed results and make the necessary updates. ➡️ Link to detailed report: Files changed |
|
❗️Oh no, some Vale linting found issues! Please check the Files change tab for detailed results and make the necessary updates. ➡️ Link to detailed report: Files changed |
|
❗️Oh no, some Vale linting found issues! Please check the Files change tab for detailed results and make the necessary updates. ➡️ Link to detailed report: Files changed |
|
❗️Oh no, some Vale linting found issues! Please check the Files change tab for detailed results and make the necessary updates. ➡️ Link to detailed report: Files changed |
|
|
||
| Indexes are not supported by Microsoft Fabric Synapse Data Warehouse. Any Indexes provided as a configuration is ignored by the adapter. | ||
| Learn more about these parameters in BigQuery's docs: | ||
| - [materialized_view_option_list](https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#materialized_view_option_list) |
There was a problem hiding this comment.
this shouldn't be flagged as a typo.
weird, the parameter names in the table above aren't getting flagged. oh i see the difference! the square brackets
|
closing as testing done and approved by Ly |
What are you changing in this pull request and why?
Testing linter with several files