-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in the on_configuration_change config on relevant pages #5940
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@matthewshaver is attempting to deploy a commit to the dbt-labs Team on Vercel. A member of the Team first needs to authorize it. |
Editorial changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @alison985 !
Will take up the additional questions as an issue to address! |
What are you changing in this pull request and why?
on_configuration_change
to the possible model configurations list.on_configuration_change
page to other pages that may have an interaction with it.I did not:
on_configuration_change
into the doc pages. I linked to it so it's at least on those pages. If you want to edit them more, they are easily gathered for you in this PR. I don't promise it's a complete list.Questions I think are relevant to include or clarify:
on_configuration_change
interact with--defer
?identifier
andalias
? If it's database structure and the database object name already exists because it was added manually outside of dbt will it drop/delete that object even though it has no information about it(and hence can't know whether it's allowed to have the power to drop/delete it)?on_configuration_change
specified by the dbt AE?grants
?on_configuration_change
and your adapter doesn't support it?Please go ahead and change it however you want as I'm unlikely to get back to this PR to make any changes myself in a timely manner.
Checklist