Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(spark-setup): improve namespace caveat description #5952

Merged
merged 5 commits into from
Aug 27, 2024
Merged

docs(spark-setup): improve namespace caveat description #5952

merged 5 commits into from
Aug 27, 2024

Conversation

dargmuesli
Copy link
Contributor

What are you changing in this pull request and why?

Added details to the namespace caveat description for Spark.

Checklist

@dargmuesli dargmuesli requested a review from a team as a code owner August 21, 2024 15:20
@welcome Welcome
Copy link

welcome bot commented Aug 21, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@vercel Vercel
Copy link

vercel bot commented Aug 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Aug 27, 2024 2:48pm

@runleonarun runleonarun added the new contributor Label for first-time contributors label Aug 21, 2024
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Aug 21, 2024
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Aug 21, 2024
@dargmuesli
docs(spark-setup): improve namespace caveat description
3101ab8 
A more detailed description would've saved me quite a bit of time at dbt setup.
@github-actions github-actions bot added size: x-small This change will take under 3 hours to fix. and removed size: small This change will take 1 to 2 days to address labels Aug 21, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 27, 2024

@mirnawong1 is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

mirnawong1
mirnawong1 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @dargmuesli ! thanks for opening this up and happy to merge this for you! made some small tweaks and looks great otherwise!

@mirnawong1 mirnawong1 merged commit 0e5b136 into dbt-labs:current Aug 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dargmuesli @mirnawong1 @runleonarun