Add athena ref page #5961
Merged
Add athena ref page #5961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
matthewshaver
commented
Aug 22, 2024
amychen1776
reviewed
Aug 22, 2024
| - `data_cell_filters` management can't be automated outside dbt because the filter can't be attached to the table which doesn't exist. Once you `enable` this config, dbt will set all filters and their permissions during every dbt run. Such approach keeps the actual state of row level security configuration actual after every dbt run and apply changes if they occur: drop, create, update filters and their permissions. | ||
| - Any tags listed in `lf_inherited_tags` should be strictly inherited from the database level and never overridden at the table and column level | ||
| - Currently `dbt-athena` does not differentiate between an inherited tag association and an override of same it made previously | ||
| > - For example, If an inherited tag is overridden by an `lf_tags_config` value in one DBT run, and that override is removed prior to a subsequent run, the prior override will linger and no longer be encoded anywhere (in e.g. Terraform where the inherited value is configured nor in the DBT project where the override previously existed but now is gone) |
There was a problem hiding this comment.
Suggested change
| > - For example, If an inherited tag is overridden by an `lf_tags_config` value in one DBT run, and that override is removed prior to a subsequent run, the prior override will linger and no longer be encoded anywhere (in e.g. Terraform where the inherited value is configured nor in the DBT project where the override previously existed but now is gone) | |
| > - For example, If an inherited tag is overridden by an `lf_tags_config` value in one dbt run, and that override is removed prior to a subsequent run, the prior override will linger and no longer be encoded anywhere (in e.g. Terraform where the inherited value is configured nor in the dbt project where the override previously existed but now is gone) |
amychen1776
reviewed
Aug 22, 2024
amychen1776
reviewed
Aug 22, 2024
| The materialization also supports invalidating hard deletes. Check | ||
| the [docs](https://docs.getdbt.com/docs/build/snapshots#hard-deletes-opt-in) to understand usage. | ||
|
|
||
| ### Working example |
There was a problem hiding this comment.
Please delete the working example. I don't think we need it
nghi-ly
reviewed
Aug 22, 2024
|
|
||
| | Parameter | Default | Description | | ||
| |-----------|---------|-------------| | ||
| | `external_location` | None | The full S3 path to where the table will be saved. Only works with incremental models. Doesn't work with Hive table with `ha` set to `true`. | |
There was a problem hiding this comment.
- sugg: rewording first sentence so it's active voice (vs passive)
- sugg: is the indefinite article missing in the 3rd sentence?
| 'disabled' as status | ||
| ``` | ||
|
|
||
| By default, the materialization keeps the last 4 table versions,but you can change it by setting `versions_to_keep`. |
There was a problem hiding this comment.
sugg moving this sentence to above the code block. feels like this could get lost in the scanning
|
|
||
| ### Update glue data catalog | ||
|
|
||
| Persist resource descriptions as column and relation comments to the glue data catalog, and meta as [glue table properties](https://docs.aws.amazon.com/glue/latest/dg/tables-described.html#table-properties) and [column parameters](https://docs.aws.amazon.com/glue/latest/webapi/API_Column.html). By default, documentation persistence is disabled, but it can be enabled for specific resources or groups of resources as needed. |
There was a problem hiding this comment.
i'm having a hard time reading and grokking the first sentence. sugg rewording to improve clarity
sugg updating second sentence to be in active voice
There was a problem hiding this comment.
Yeah, I'm struggling here too. @amychen1776 Any ideas on how to clean this thought up?
There was a problem hiding this comment.
Maybe something like this:
You can persist your column and model level descriptions to the Glue Data Catalog as glue table properties and column parameters. To enable this, you will need to set the configuration to true as show below.
nghi-ly
reviewed
Aug 24, 2024
matthewshaver
commented
Aug 29, 2024
Co-authored-by: Ly Nguyen <[email protected]>
Adding description
matthewshaver
commented
Aug 29, 2024
Co-authored-by: Ly Nguyen <[email protected]>
matthewshaver
commented
Aug 29, 2024
matthewshaver
commented
Aug 29, 2024
…etdbt.com into athena-reference
matthewshaver
commented
Aug 29, 2024
matthewshaver
commented
Aug 29, 2024
matthewshaver
commented
Aug 29, 2024
matthewshaver
commented
Aug 29, 2024
matthewshaver
commented
Aug 29, 2024
matthewshaver
commented
Aug 29, 2024
matthewshaver
commented
Aug 29, 2024
matthewshaver
commented
Aug 29, 2024
matthewshaver
commented
Aug 29, 2024
matthewshaver
commented
Aug 29, 2024
matthewshaver
commented
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Adding the Amazon Athena /ref page
Additionally organized the adapter ref page sidebar in alphabetical order
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.jswebsite/vercel.jsonnpm run buildto update the links that point to deleted pages