Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blockquote text color in admonitions #5990

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Conversation

JKarlavige
Copy link
Collaborator

@JKarlavige JKarlavige commented Aug 29, 2024

What are you changing in this pull request and why?

This adjusts the CSS for blockquotes within admonitions, to adapt the color based on admonition background color and dark mode status

Previews

On the live site, the blockquote may pull the incorrect text color based on darkmode status, making the text unreadable, as it occurs on this live page.

Verify the correct text color is applied for blockquotes in admonitions in the previews below:


TODO

  • Remove demo updates from intro page

@JKarlavige JKarlavige requested a review from a team as a code owner August 29, 2024 14:38
Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Aug 29, 2024 7:59pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Aug 29, 2024
@JKarlavige JKarlavige changed the title Fix blockquote text color Fix blockquote text color in admonitions Aug 29, 2024
Copy link
Contributor

@matthewshaver matthewshaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JKarlavige !

@github-actions github-actions bot added size: x-small This change will take under 3 hours to fix. and removed size: small This change will take 1 to 2 days to address labels Aug 29, 2024
@JKarlavige JKarlavige merged commit 0986a76 into current Aug 29, 2024
10 checks passed
@JKarlavige JKarlavige deleted the fix-blockquote-text-color branch August 29, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants