Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EOL banners #6009

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Update EOL banners #6009

merged 3 commits into from
Sep 4, 2024

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Updating the EOL banner texts, removing versions and fixing links in the text.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested a review from a team as a code owner September 4, 2024 14:36
@vercel Vercel
Copy link

vercel bot commented Sep 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 4, 2024 3:14pm

@github-actions github-actions bot added Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. labels Sep 4, 2024
mirnawong1
mirnawong1 reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocker but i wonder if we should also link to the latest stable version in the 1.9 beta banner too.

Screenshot 2024-09-04 at 15 56 50

@matthewshaver matthewshaver enabled auto-merge (squash) September 4, 2024 14:59
mirnawong1
mirnawong1 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and links all work! lgtm!

@mirnawong1 mirnawong1 merged commit 5322718 into current Sep 4, 2024
10 checks passed
@mirnawong1 mirnawong1 deleted the EOL-banner branch September 4, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewshaver @mirnawong1