-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove styles page #6278
remove styles page #6278
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mirnawong1, just requesting one change to get the redirect working. Once adjusted this should be good to 🚢 !
website/vercel.json
Outdated
"source": "/src/pages/styles.js", | ||
"destination": "https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/adding-page-components.md", | ||
"permanent": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the redirect isn't being picked up here: https://docs-getdbt-com-git-remove-style-dbt-labs.vercel.app/styles
The source
here just needs to match the live url of the page, which would be /styles
in this case!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much for reviewing @JKarlavige ! I've updated this on my end and ready for re review whenever you can 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! verified the redirect is firing correctly when hitting https://docs-getdbt-com-git-remove-style-dbt-labs.vercel.app/styles
you're the best, thank you so much for the quick review @JKarlavige ! |
Check your created Crawler Check your created index on your Algolia Application |
this page: https://docs.getdbt.com/styles can be found when googling 'styles'.
this pr finds a permanent home fort he content in teh 'contributing' section of the repo.
Resolves #5844