Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove styles page #6278

Merged
merged 3 commits into from
Oct 16, 2024
Merged

remove styles page #6278

merged 3 commits into from
Oct 16, 2024

Conversation

mirnawong1
Copy link
Contributor

this page: https://docs.getdbt.com/styles can be found when googling 'styles'.

this pr finds a permanent home fort he content in teh 'contributing' section of the repo.

Resolves #5844

@mirnawong1 mirnawong1 requested a review from a team as a code owner October 11, 2024 10:59
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 16, 2024 2:28pm

@github-actions github-actions bot added size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels Oct 11, 2024
Copy link
Collaborator

@JKarlavige JKarlavige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mirnawong1, just requesting one change to get the redirect working. Once adjusted this should be good to 🚢 !

Comment on lines 6 to 8
"source": "/src/pages/styles.js",
"destination": "https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/adding-page-components.md",
"permanent": true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the redirect isn't being picked up here: https://docs-getdbt-com-git-remove-style-dbt-labs.vercel.app/styles

The source here just needs to match the live url of the page, which would be /styles in this case!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much for reviewing @JKarlavige ! I've updated this on my end and ready for re review whenever you can 🙏

website/vercel.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@JKarlavige JKarlavige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! verified the redirect is firing correctly when hitting https://docs-getdbt-com-git-remove-style-dbt-labs.vercel.app/styles

:shipit:

@mirnawong1
Copy link
Contributor Author

you're the best, thank you so much for the quick review @JKarlavige !

@mirnawong1 mirnawong1 merged commit f1e38ab into current Oct 16, 2024
7 checks passed
@mirnawong1 mirnawong1 deleted the remove-style branch October 16, 2024 14:33
Copy link
Contributor

Check your created Crawler

Check your created index on your Algolia Application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address trigger-crawl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify where to place the dbt styles doc
2 participants