Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update external links to SL instructions #6285

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

joaoclemencio-dbtlabs
Copy link
Contributor

@joaoclemencio-dbtlabs joaoclemencio-dbtlabs commented Oct 14, 2024

What are you changing in this pull request and why?

The current link to Lightdash's Semantic Layer instructions (https://docs.lightdash.com/guides/dbt-semantic-layer/) is not working. This seems to be the updated one: https://docs.lightdash.com/references/dbt-semantic-layer

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@joaoclemencio-dbtlabs joaoclemencio-dbtlabs requested a review from a team as a code owner October 14, 2024 20:23
Copy link

welcome bot commented Oct 14, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 15, 2024 8:36am

@runleonarun runleonarun added the new contributor Label for first-time contributors label Oct 14, 2024
@github-actions github-actions bot added size: x-small This change will take under 3 hours to fix. content Improvements or additions to content and removed size: x-small This change will take under 3 hours to fix. labels Oct 14, 2024
@github-actions github-actions bot added the size: x-small This change will take under 3 hours to fix. label Oct 15, 2024
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Oct 15, 2024
@joaoclemencio-dbtlabs joaoclemencio-dbtlabs changed the title Update link to Lightdash SL instructions Update links to SL instructions Oct 15, 2024
@joaoclemencio-dbtlabs joaoclemencio-dbtlabs changed the title Update links to SL instructions Update external links to SL instructions Oct 15, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @joaoclemencio-dbtlabs wow thank you so much for opening this up and catching this! great addition and will get this merged for you ✨!

@mirnawong1 mirnawong1 merged commit edfbc20 into current Oct 15, 2024
6 checks passed
@mirnawong1 mirnawong1 deleted the joaoclemencio-dbtlabs-patch-1 branch October 15, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants