Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated images so they are more up to date #6490

Open
wants to merge 1 commit into
base: current
Choose a base branch
from
Open

Updated images so they are more up to date #6490

wants to merge 1 commit into from
+0 −2

Conversation

nataliefiann
Copy link
Contributor

@nataliefiann nataliefiann commented Nov 14, 2024 •
edited by github-actions bot
Loading

What are you changing in this pull request and why?

I have created this PR so that it's up to date / current with most recent adapter upgrade info

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@nataliefiann nataliefiann requested a review from a team as a code owner November 14, 2024 21:50
@vercel Vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 14, 2024 9:53pm

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix. labels Nov 14, 2024
matthewshaver
matthewshaver reviewed Nov 14, 2024
View reviewed changes
website/docs/guides/adapter-creation.md
@@ -1345,8 +1345,6 @@ Breaking this down:
<Lightbox src="/img/adapter-guide/3-additional-resources.png" title="more resources"/>
- Implementation instructions:
<Lightbox src="/img/adapter-guide/4-installation.png" title="more installation"/>
- Future plans
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nataliefiann @matthewshaver