Unit tests #133
Merged
Unit tests #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joellabes
approved these changes
Jul 25, 2022
| $EDITOR config.json | ||
|
|
||
| # Export the JSON credentials into an environment variable | ||
| export CONFIG=$(<config.json) |
There was a problem hiding this comment.
I'm unfamiliar with this syntax, so just checking that the lonely < is meant to be there?
jtcohen6
approved these changes
Jul 25, 2022
Comment on lines
+98
to
+100
| "0.8.0a1", | ||
| "0.8.0b2", | ||
| "0.8.0rc3", |
There was a problem hiding this comment.
👍
#130 will move these up to the "supported" category
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #131, resolves #132, related to #67, supports #130
Overview
Implementation details
Used
pytestas the testing framework.There was a naming conflict between the local
hubcap/cmd.pymodule and thegit/cmd.pymodule within thegitpythonpackage. So I renamed the former.Used these test cases (linked from the SemVer docs). Added a couple test cases we've seen for dbt adapters and packages.