-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added caution message for mouse-zoomable conflict with elasticX #1623
base: develop
Are you sure you want to change the base?
added caution message for mouse-zoomable conflict with elasticX #1623
Conversation
Thanks @privateOmega! Related: #987, I am tempted to do what is probably expected and turn off (Or perhaps, since it would also be surprising for a parameter to change on its own, define elasticX as only active on render not redraw, if either of these features are enabled.) |
@gordonwoodhull Since you have plans to fix it. I am abandoning the PR. |
I’m going to reopen this as a reminder to fix this. I’m currently on vacation but I think it will be a quick fix when I get back. Otherwise I think we would have to document it in at least three places! |
@gordonwoodhull Sure. Sounds perfect. |
I started this on the
Besides calculating the domain only on render, it also sets Everything works and I have converted many of the examples to use I did see a performance regression on the "focus dynamic interval" example, which I'll need to look into before releasing this (as 3.2, to be merged into 4.0, also to be released soon). |
@gordonwoodhull I found that I was unable to zoom-in to my graph even with mouseZoomable(true) and documentation didn't explicity specify this case.
After some googling I found your answer in SO, and I thought users in future shouldn't be wasting time on this. The commit contains update in documentation and rebuild docs.
This can be removed once the below is the case.