Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying grunt and bower #925

Closed
wants to merge 4 commits into from
Closed

Simplifying grunt and bower #925

wants to merge 4 commits into from

Conversation

ruhley
Copy link
Contributor

@ruhley ruhley commented Apr 29, 2015

  • Moving grunt tasks and config into seperate files
  • Minimising the files downloaded when installing through bower

And an old pull request

@mtraynham
Copy link
Contributor

I'm all for splitting things out, but is this a bit overkill? I can see us breaking out the registerGruntMultitask portions into modules as that emphasizes a clear distinction between code and config. But the rest of it is just configuration, which seems like it would be really hard to understand split out in this way.

Not saying this is wrong, but would love to hear other opinions.

@gordonwoodhull
Copy link
Contributor

@mtraynham, I was waiting for your opinion on this. I agree that it makes sense to separate out code, especially the big blocks, but the configuration should stay in the Gruntfile.

Some more of the big blocks can better be implemented using grunt plug-ins, too. (I'm looking at the examples index in particular.)

@gordonwoodhull
Copy link
Contributor

For minimizing the bower download, it looks like #935 is more specific. I intend to merge the parts splitting out the grunt code, and the options stuff, on master (2.0 branch).

@gordonwoodhull gordonwoodhull added this to the v2.0 milestone May 24, 2015
@ruhley
Copy link
Contributor Author

ruhley commented May 24, 2015

For the bower.json ignore property you can either go with #935 listing everything you want to ignore. I prefer to ignore everything and then include only the couple of files I want.

I also prefer to split all grunt config into different files as each file is small and modular.

But as I said these are just preferences, that I thought you might like.

@gordonwoodhull
Copy link
Contributor

It does look a lot simpler to ignore everything and then "not-ignore" the couple of files that are needed; I think I'll go with that. Looks like we need to not-ignore LICENSE as well.

@mtraynham
Copy link
Contributor

I'm fine with either resolution, just make sure to update the bower version :)

@gordonwoodhull
Copy link
Contributor

Yup. Can't we generate it from package.json somehow?

There is another PR to add component.json: more build steps, more error-prone redundancies.

@Tim-Intellipharm
Copy link

Would you like me to close this pull request and create another with just the bower.json ignore updates? I can set it to something like ```["", "!dc.", "LICENSE"]. I can also look into creating a custom grunt task that sets the bower.json version to the same as in package.json.

@mtraynham
Copy link
Contributor

There is grunt-bump. I'd be inclined to use something that already exists than us maintain more build scripts.

Maybe turn off the push option though. Wouldn't want it to accidentally push code.

@gordonwoodhull
Copy link
Contributor

Thanks @Tim-Intellipharm, but I can piece apart the changes easily enough.

Wow @mtraynham, grunt-bump is over the top. But I may be able to get it to do just what I want. Thanks!

@ruhley ruhley closed this May 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.stack() with .options()
4 participants