-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplifying grunt and bower #925
Conversation
Conflicts: dc.min.js dc.min.js.map
I'm all for splitting things out, but is this a bit overkill? I can see us breaking out the Not saying this is wrong, but would love to hear other opinions. |
@mtraynham, I was waiting for your opinion on this. I agree that it makes sense to separate out code, especially the big blocks, but the configuration should stay in the Gruntfile. Some more of the big blocks can better be implemented using grunt plug-ins, too. (I'm looking at the examples index in particular.) |
For minimizing the bower download, it looks like #935 is more specific. I intend to merge the parts splitting out the grunt code, and the options stuff, on master (2.0 branch). |
For the bower.json ignore property you can either go with #935 listing everything you want to ignore. I prefer to ignore everything and then include only the couple of files I want. I also prefer to split all grunt config into different files as each file is small and modular. But as I said these are just preferences, that I thought you might like. |
It does look a lot simpler to ignore everything and then "not-ignore" the couple of files that are needed; I think I'll go with that. Looks like we need to not-ignore LICENSE as well. |
I'm fine with either resolution, just make sure to update the bower version :) |
Yup. Can't we generate it from package.json somehow? There is another PR to add component.json: more build steps, more error-prone redundancies. |
Would you like me to close this pull request and create another with just the bower.json ignore updates? I can set it to something like ```["", "!dc.", "LICENSE"]. I can also look into creating a custom grunt task that sets the bower.json version to the same as in package.json. |
There is grunt-bump. I'd be inclined to use something that already exists than us maintain more build scripts. Maybe turn off the |
Thanks @Tim-Intellipharm, but I can piece apart the changes easily enough. Wow @mtraynham, grunt-bump is over the top. But I may be able to get it to do just what I want. Thanks! |
And an old pull request