GRPC to issuer from apigw in order to make sdjwt. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matskramer
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Issues find by Goland (may be in files not included in this pull request):
File queue_vc_persistent_delete.go has wrong comment in
// VCPersistentSave holds the ladok delete signed queue
type VCPersistentDelete struct {
File error.go has type assertion on erros fails on wrapped errors, user errors.As (4 places)?
File docs/verifier/swagger.json missing required properties 'title' and 'version'
| @@ -52,7 +53,7 @@ type CreateCredentialReply struct { | |||
| } | |||
|
|
|||
| // CreateCredential creates a credential | |||
| func (c *Client) CreateCredential(ctx context.Context, req *CreateCredentialRequest) (*CreateCredentialReply, error) { | |||
| func (c *Client) MakeSDJWT(ctx context.Context, req *CreateCredentialRequest) (*CreateCredentialReply, error) { | |||
| func (c *Client) Revoke(ctx context.Context, req *RevokeRequest) (*RevokeReply, error) { | ||
| optInsecure := grpc.WithTransportCredentials(insecure.NewCredentials()) | ||
|
|
||
| conn, err := grpc.Dial(c.cfg.Registry.GRPCServer.Addr, optInsecure) |
There was a problem hiding this comment.
Dial is deprecated: use NewClient instead (inspect in GoLand)
| @@ -20,7 +21,7 @@ type Apiv1 interface { | |||
|
|
|||
| // credential endpoints | |||
| Revoke(ctx context.Context, req *apiv1.RevokeRequest) (*apiv1.RevokeReply, error) | |||
| Credential(ctx context.Context, req *apiv1.CredentialRequest) (*apiv1.CredentialReply, error) | |||
| Credential(ctx context.Context, req *apiv1.CredentialRequest) (*apiv1_issuer.MakeSDJWTReply, error) | |||
There was a problem hiding this comment.
Remove Make in struct name?
| // Build SDJWT | ||
| var sdjwt *gosdjwt.SDJWT | ||
| //var err error | ||
| switch req.DocumentType { |
There was a problem hiding this comment.
Some duplicate code below, use factory to create generic sdjwt client depending on DocumentType?
| @@ -157,7 +127,7 @@ func (c *Client) Revoke(ctx context.Context, req *RevokeRequest) (*RevokeReply, | |||
|
|
|||
| optInsecure := grpc.WithTransportCredentials(insecure.NewCredentials()) | |||
|
|
|||
| conn, err := grpc.Dial(c.cfg.Registry.RPCServer.Addr, optInsecure) | |||
| conn, err := grpc.Dial(c.cfg.Registry.GRPCServer.Addr, optInsecure) | |||
| ) | ||
|
|
||
| // MakeSDJWT creates an sd-jwt and return it, else error | ||
| func (s *Service) MakeSDJWT(ctx context.Context, in *apiv1_issuer.MakeSDJWTRequest) (*apiv1_issuer.MakeSDJWTReply, error) { |
| // RPCServer holds the rpc configuration | ||
| type RPCServer struct { | ||
| // GRPCServer holds the rpc configuration | ||
| type GRPCServer struct { | ||
| Addr string `yaml:"addr" validate:"required"` | ||
| Insecure bool `yaml:"insecure"` |
There was a problem hiding this comment.
Insecure --> Secure (more easy to read and understand) but usage must also be switched then?
|
|
||
| option go_package = "vc/internal/gen/issuer/apiv1.issuer"; | ||
|
|
||
| import "google/protobuf/timestamp.proto"; | ||
| import "v1-status-model.proto"; | ||
| //import "google/protobuf/timestamp.proto"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for issuance of sdjwt credential.