Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1077 Add a get method to get the previously reflected method retrieves #1078

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wayfarer3130
Copy link
Contributor

If you run dcm4che imageio opencv decompression under JDK >=11, you get a lot of error messages about reflection becoming illegal shortly and being disallowed. The changes attached fix this as long as you implement the appropriate methods to get the path name and/or random access file object on the response.

@nroduit
Copy link
Member

nroduit commented Dec 20, 2021

See my comment

@wayfarer3130
Copy link
Contributor Author

@gunterze - what is your opinion on the change here. I can add supporting unit tests to make the quality gate pass, but I mean on the underlying issue. My thought is that the code shouldn't rely on special java allow internal access flags to enable it to work, but should work on public methods, which is what I modified the code to do.
@nroduit - I know you said that there is a longer term change to just be able to direct read from the IIS, but in the meantime, how do you feel about having the extra implementations to allow it to work without the forbidden reflection.

@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants