Basic datalink configuration. #3181
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3181 +/- ##
===========================================
+ Coverage 45.75% 45.84% +0.08%
===========================================
Files 474 477 +3
Lines 25819 25880 +61
Branches 4521 4531 +10
===========================================
+ Hits 11813 11864 +51
- Misses 13985 13995 +10
Partials 21 21
|
DanAlbert
force-pushed
the
datalink
branch
2 times, most recently
from
ae2707e
to
b1efa8e
Compare
This is a stop-gap solution so we can get a release out that supports datalink as quickly as possible. It would be better to assign these early so the player can select which flights should be their team/donors, but for that we need to keep a registry in Game, plumb it through to each Flight creation (and there are many callsites for that), subscribe each flight to its datalink contacts (so disbanded flights do not remain part of a network), and of course the UI itself. That'll come later. Follow up work: * Filtering to only apply for the airframes that can use it * Selection of team/donors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stop-gap solution so we can get a release out that supports datalink as quickly as possible. It would be better to assign these early so the player can select which flights should be their team/donors, but for that we need to keep a registry in Game, plumb it through to each Flight creation (and there are many callsites for that), subscribe each flight to its datalink contacts (so disbanded flights do not remain part of a network), and of course the UI itself. That'll come later.