APCV-1367 and APCV-1268 - CS conformance issue fix

[palatsangeetha]

-Fix for incorrect prompt and updated the GET actions title for pagination scenarios

[jkosternl]

Looking good, from a Java point of view.
If you're not on a tight schedule on CS, adding an unit test to verify the second prompt is correct, helps securing this.

[jkosternl]

Hi @palatsangeetha, if you're still coding in CS, can you also check this line in CsAction class?
if (!dsp.equals(updatedDsp)) dsp.set(updatedDsp); because that equals method is comparing different types of objects, and therefore is always not equal. You can also improve that later, if you don't like it now.

[palatsangeetha]

Hi @palatsangeetha, if you're still coding in CS, can you also check this line in CsAction class? if (!dsp.equals(updatedDsp)) dsp.set(updatedDsp); because that equals method is comparing different types of objects, and therefore is always not equal. You can also improve that later, if you don't like it now.

@jkosternl Thanks for the comments on the CS PR, I will take care of it as part of a next change as changing that and then testing all flows might take some time.

[douradofrazer]

@CodiumAI-Agent /improve

[CodiumAI-Agent]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible bug	Add null checks to prevent runtime exceptions Consider checking for null values in sspSupplier.get() before calling toJson() to prevent potential NullPointerExceptions. commercial-schedules/src/main/java/org/dcsa/conformance/standards/cs/action/CsGetRoutingsAction.java [42-45] return previousAction instanceof CsGetRoutingsAction ? "Send a GET point to point routings request to fetch the second results page, using the cursor retrieved from the headers of the response of the first GET request." : "Send a GET point to point routings request with the following parameters: " - + sspSupplier.get().toJson().toPrettyString(); + + (sspSupplier.get() != null ? sspSupplier.get().toJson().toPrettyString() : "No parameters available"); Suggestion importance[1-10]: 8 Why: Adding a null check for sspSupplier.get() is a practical suggestion to prevent potential NullPointerExceptions, which could lead to runtime errors. This enhances the robustness of the code.	8
Maintainability	Refactor to reduce code duplication and enhance maintainability Refactor the constructor to avoid duplication in the ternary operation by extracting the logic into a private method. commercial-schedules/src/main/java/org/dcsa/conformance/standards/cs/action/CsGetPortSchedulesAction.java [19-26] super( subscriberPartyName, publisherPartyName, previousAction, - (previousAction instanceof CsGetPortSchedulesAction) - ? "GetPortSchedules (second page)" - : "GetPortSchedules", + determineActionLabel(previousAction), 200); Suggestion importance[1-10]: 7 Why: The suggestion to refactor the constructor by extracting the ternary operation into a private method is valid. It enhances code maintainability by reducing duplication and improving readability.	7
Enhancement	Improve code reuse and clarity by abstracting repetitive conditional logic into a method Optimize the conditional logic by creating a method to handle the repeated conditional checks across different actions. commercial-schedules/src/main/java/org/dcsa/conformance/standards/cs/action/CsGetVesselSchedulesAction.java [23-30] super( subscriberPartyName, publisherPartyName, previousAction, - (previousAction instanceof CsGetVesselSchedulesAction) - ? "GetVesselSchedules (second page)" - : "GetVesselSchedules", + getActionLabel(previousAction, CsGetVesselSchedulesAction.class, "GetVesselSchedules"), 200); Suggestion importance[1-10]: 7 Why: The suggestion to abstract repetitive conditional logic into a method improves code clarity and reuse. It is a beneficial enhancement for maintaining consistency across similar actions.	7