STNG-165 Run one scenario in AWS dev fully end-to-end #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactored quite a bit, to increase on code reuse
…ly the same code and parameters does work
jkosternl
commented
Oct 8, 2024
| @@ -16,9 +16,6 @@ jobs: | |||
| steps: | |||
| - name: Checkout repository | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| ref: ${{ env.AWS_ENVIRONMENT }} | |||
| # Enforces only AWS env name matching branches are checkout and deployed. | |||
There was a problem hiding this comment.
This was a pain.. I was making experimental changes in the pom.xml file for the new situation, but they were not applied, because I changed the checkout here to force it to dev HEAD instead.
The enforcing of the right environment is also already guaranteed by line 5 and line 10 of this file.
jkosternl
commented
Oct 8, 2024
| <junit.excludedTags>WebUI</junit.excludedTags> | ||
| </properties> | ||
| </profile> | ||
| </profiles> |
There was a problem hiding this comment.
I introduced profiles to make it more clear and easy to use and select which profile you'd like to use. By default, the first profile is used.
gj0dcsa
approved these changes
Oct 8, 2024
palatsangeetha
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created test
AWSEnvironmentTestwhich runs Ebl, Conformance TD-only, Carrier fully end-to-end.Created the SeleniumTestBase for code reuse. It does not start Spring Boot itself.
Sorry for the refactoring and changes in the same PR.. which makes it harder to see the changes.