Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-1821-Updated the request json examples from the latest API spec #184

Merged
merged 1 commit into from
Oct 8, 2024
Merged

DT-1821-Updated the request json examples from the latest API spec #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 38 additions & 22 deletions ...ssuance/src/main/resources/standards/eblissuance/messages/eblissuance-v3.0.0-request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"cargoMovementTypeAtDestination": "FCL",
"issueDate": "2020-12-12",
"serviceContractReference": "HHL51800000",
"contractQuotationReference": "12345",
"contractQuotationReference": "HHL1401",
"declaredValue": 1231.1,
"declaredValueCurrency": "DKK",
"carrierCode": "MMCU",
Expand Down Expand Up @@ -87,70 +87,86 @@
"UNLocationCode": "NLAMS"
},
"invoicePayableAt": {
"UNLocationCode": "DKAAR"
"UNLocationCode": "NLAMS"
},
"partyContactDetails": [
{
"name": "DCSA test person",
"email": "[email protected]"
"name": "Henrik",
"phone": "+45 51801234"
},
{
"name": "Henrik",
"phone": "+45 51801234"
}
],
"documentParties": {
"shipper": {
"partyName": "DCSA CTK",
"partyName": "IKEA Denmark",
"partyContactDetails": [
{
"name": "DCSA test person",
"email": "[email protected]"
"name": "Henrik",
"phone": "+45 51801234"
},
{
"name": "Henrik",
"phone": "+45 51801234"
}
]
},
"consignee": {
"partyName": "CONSIGNEE_LEGAL_NAME_PLACEHOLDER",
"identifyingCodes": [
{
"codeListProvider": "EPUI",
"codeListProvider": "W3C",
"partyCode": "CONSIGNEE_PARTY_CODE_PLACEHOLDER",
"codeListName": "CONSIGNEE_CODE_LIST_NAME_PLACEHOLDER"
}
Comment on lines 119 to 123
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these need to be turned into a placeholder objects. It is exceedingly likely that the parties do not have a fixed codeListProvider for this party.

I feel this basically applies to all parties with placeholders in them.

],
"partyContactDetails": [
{
"name": "DCSA test person",
"email": "[email protected]"
"name": "Henrik",
"phone": "+45 51801234"
},
{
"name": "Henrik",
"phone": "+45 51801234"
}
]
},
"issuingParty": {
"partyName": "Hyundai",
"address": {
"street": "The street name would be here",
"city": "... and here the city",
"countryCode": "KR"
"street": "Ruijggoordweg",
"city": "Amsterdam",
"countryCode": "NL"
},
"identifyingCodes": [
{
"codeListProvider": "SMDG",
"codeListName": "LCL",
"partyCode": "HMM"
"codeListProvider": "W3C",
"partyCode": "MSK",
"codeListName": "DID"
}
Comment on lines 137 to 148
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The party code is for MSK (and should probably not use W3C + DID. It looks like an SMDG code instead). However, the partyName is for Hyundai (HMM).

I assume the original example is wrong. Probably the issuing party should be made a placeholder that the issuer can provide.

]
},
"notifyParties": [
{
"partyName": "DCSA CTK",
"partyName": "IKEA Denmark",
"partyContactDetails": [
{
"name": "DCSA test person",
"email": "[email protected]"
"name": "Henrik",
"phone": "+45 51801234"
},
{
"name": "Henrik",
"phone": "+45 51801234"
}
]
}
],
"other": [
{
"party": {
"partyName": "DCSA CTK Service Contract Owner"
"partyName": "Asseco Denmark"
},
"partyFunction": "SCO"
}
Expand Down Expand Up @@ -188,7 +204,7 @@
"isShipperOwned": false,
"seals": [
{
"number": "DCSA-CTK-1234"
"number": "VET123"
}
]
}
Expand All @@ -199,7 +215,7 @@
"sendToPlatform": "SEND_TO_PLATFORM_PLACEHOLDER",
"identifyingCodes": [
{
"codeListProvider": "EPUI",
"codeListProvider": "W3C",
"partyCode": "ISSUE_TO_PARTY_CODE_PLACEHOLDER",
"codeListName": "ISSUE_TO_CODE_LIST_NAME_PLACEHOLDER"
}
Expand Down