STNG-8 Use concurrent versions of HashMap, TreeMap, HashSet #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te synchronized keywords at EBL Surrender. * Note that 'synchronized' on a method does only synchronize threads on that particular method, not on all methods in the same class also changing the same maps! * EBL Surrender: Remove overridden methods, which just only call super (without it, it behaves the same)
jkosternl
changed the title
gj0dcsa
requested changes
Oct 14, 2024
gj0dcsa
requested changes
Oct 16, 2024
| private final LinkedList<JsonNode> pendingActions = new LinkedList<>(); | ||
|
|
||
| synchronized void clear() { |
There was a problem hiding this comment.
Please let's discuss this before proceeding with the change, because "synchronized" was in place because most operations affect both collections in parallel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use concurrent versions of HashMap, TreeMap, HashSet, and remove 2 obsolete synchronized keywords at EBL Surrender.
Question: should I perform any extra verification on the correctness of our code, except for all the checks we've build in our GH pipelines already?