DT-716 first set changes #23
Conversation
...ng/src/main/java/org/dcsa/conformance/standards/booking/party/CarrierScenarioParameters.java
Outdated
Show resolved
Hide resolved
| CarrierScenarioParameters carrierScenarioParameters = | ||
| new CarrierScenarioParameters( | ||
| "Carrier Service %d".formatted(RANDOM.nextInt(999999)), | ||
| generateSchemaValidVesselIMONumber()); | ||
| generateSchemaValidVesselIMONumber(), | ||
| "service name",null,null,null,null); |
There was a problem hiding this comment.
I would assume there nulls should have real values in them. If not, the framework would have provided null where a real value should have been and I would expect a schema validation error then.
There was a problem hiding this comment.
This function was never called.. I tried and tested it. The checks were fine.. I m bit confused.. Hence I put the null values.. I will provide the real values in them.
There was a problem hiding this comment.
@gj0dcsa Why do we have this function if it is never called?
There was a problem hiding this comment.
That method is the carrier implementation of the SupplyCSP action, and if you put a breakpoint on it you can see that it gets called if you run the all-in-one booking scenarios in automated mode.
If you run in manual mode, testing a carrier, because isInputRequired() returns true, instead of calling that method on a synthetic carrier, the orchestrator relies on the web UI to ask the user to enter them manually.
There was a problem hiding this comment.
Thanks George for the info..
booking/src/main/java/org/dcsa/conformance/standards/booking/party/Carrier.java
Outdated
Show resolved
Hide resolved
| generateSchemaValidVesselIMONumber()); | ||
| generateSchemaValidVesselIMONumber(), | ||
| "service name", | ||
| "%07d".formatted(RANDOM.nextInt(999999)), |
There was a problem hiding this comment.
No, a random number is not valid as a HS Code. Please use a proper HS Code and the Commodity Type should match the HS Code (If the HS Code implies it is a leather goods, then Commodity Type should mention some form of leather based good).
booking/src/main/java/org/dcsa/conformance/standards/booking/party/Carrier.java
Outdated
Show resolved
Hide resolved
| "name": "Asseco DK", | ||
| "street": "Kronprinsessegade", | ||
| "name": "TODO", | ||
| "street": "TODO", | ||
| "streetNumber": "54", | ||
| "floor": "5. sal", | ||
| "postCode": "1306", |
There was a problem hiding this comment.
Please update the address (there is a TODO left here)
| "name": "Asseco DK", | ||
| "street": "Kronprinsessegade", | ||
| "name": "Mustermann", | ||
| "street": "Beispielstreet", | ||
| "streetNumber": "54", | ||
| "floor": "5. sal", | ||
| "postCode": "1306", |
There was a problem hiding this comment.
I was expecting this to be rewritten to DCSA's office or something like that. Currently, it is a mix of a Danish and whatever Beispielstreet classified as (mix of German for "example" and English for "street"?).
There was a problem hiding this comment.
For the record, this should be a real address. Though you might be able to prune out some of the fields that are not relevant (check the schema for mandatory fields)
There was a problem hiding this comment.
We used to give always a dummy address. Hence I came up with that name.
|
Since these changes reviewed and hence merging these changes. |
No description provided.