DT-780 [1/2]: Implement dataset based Json attribute validation #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gj0dcsa Could you review this one for the approach taken? It is not a full implementation of DT-780 (I did not want invest more effort into it if you disagreed with the conceptual approach). (Note: If you agree/approve, I intended merge this change and continue from here unless you say otherwise) |
gj0dcsa
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Yes, this is exactly the kind of abstraction that I expect to see appearing based on your day-to-day experience with the kind of validations that you discover that you need, with an implementation guided by what makes it easiest to write many such validations in the future.
Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
This commit provides the infrastructure to do dataset based validations. It also includes two sample checks from DT-612 to show how it would be used. Signed-off-by: Niels Thykier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides the infrastructure to do dataset based
validations. It also includes two sample checks from DT-612 to show
how it would be used.