Refactor Json content checks one more time + DT-780: Provide UN location code checks for TD #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a Json content check "container" ConformanceAction, which can
process multiple Json content checks. This provides the following
advantages:
1) The Json content checks can now be simplier
(`attribute X matches Y` rather than (`attribute X in the response
matches Y and this check is only relevant to the carrier`).
2) The "container" ConformanceAction provides a natural grouping for
all the checks in the conformance report by doing them as subchecks.
In this refactoring all the eBL checks have been streamlined to
support this new setup. Lots of duplicated checks have been removed
and some checks have been done a bit more strict (such as the
`attribute X must match X attribute from the DSP`, where we now verify
that the `DSP` has a valid value before comparing it against the
JSON).
Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
gj0dcsa
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1: Refactor Json content checks one more time
Provide a Json content check "container" ConformanceAction, which can process multiple Json content checks. This provides the following advantages:
The Json content checks can now be simplier
(
attribute X matches Yrather than (attribute X in the response matches Y and this check is only relevant to the carrier).The "container" ConformanceAction provides a natural grouping for
all the checks in the conformance report by doing them as subchecks.
In this refactoring all the eBL checks have been streamlined to support this new setup. Lots of duplicated checks have been removed and some checks have been done a bit more strict (such as the
attribute X must match X attribute from the DSP, where we now verify that theDSPhas a valid value before comparing it against the JSON).Commit 2: DT-780: Add complex validations of UNLocationCodes in TD