DT-380 #61
Merged
DT-380 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt-gt
reviewed
Jan 24, 2024
| @@ -381,6 +381,7 @@ private void generateTransportPlan(ObjectNode booking) { | |||
|
|
|||
| private void replaceShipmentCutOffTimes(ObjectNode booking) { | |||
| var shipmentCutOffTimes = booking.putArray("shipmentCutOffTimes"); | |||
| var receiptTypeAtOrigin = booking.get("receiptTypeAtOrigin").asText(null); | |||
There was a problem hiding this comment.
Throws an NPE if that field is omitted. Please use .path(...) instead of .get(...)
There was a problem hiding this comment.
Also, the .asText(null) could have been .asText("") so receiptTypeAtOrigin could never be null (there is no value in allowing null here in the first place, so there is only risks by allowing)
nt-gt
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.