Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dt 786 #71

Merged
merged 21 commits into from
Mar 22, 2024
Merged

Dt 786 #71

merged 21 commits into from
Mar 22, 2024

Conversation

preetamnpr
Copy link
Collaborator

No description provided.

nt-gt
nt-gt requested changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@nt-gt nt-gt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing scenario based checks on all payloads.

As an example, the carrier is not preserving the active reefer settings, the carrier must fail the scenario. If the shipper by mistake omits the scenario details in a UC3 (PUT) then they should also fail the scenario.

nt-gt
nt-gt requested changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@nt-gt nt-gt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some more remarks.

In addition, I do not see a fix for the remark I made inhttps://github.com//pull/71#pullrequestreview-1905776565

booking/src/main/java/org/dcsa/conformance/standards/booking/checks/BookingChecks.java Outdated Show resolved Hide resolved
...c/main/resources/standards/booking/messages/booking-api-2.0.0-Beta-1-reefer-temp-change.json Outdated Show resolved Hide resolved
booking/src/main/resources/standards/booking/messages/booking-api-2.0.0-Beta-1-dg.json Outdated Show resolved Hide resolved
booking/src/main/resources/standards/booking/messages/booking-api-2.0.0-Beta-1-reefer.json Outdated Show resolved Hide resolved
...ng/src/main/resources/standards/booking/messages/booking-api-2.0.0-Beta-1-regular-2re1c.json Outdated Show resolved Hide resolved
...src/main/resources/standards/booking/messages/booking-api-2.0.0-Beta-1-regular-cho-dest.json Outdated Show resolved Hide resolved
...src/main/resources/standards/booking/messages/booking-api-2.0.0-Beta-1-regular-cho-orig.json Outdated Show resolved Hide resolved
...ources/standards/booking/messages/booking-api-2.0.0-Beta-1-regular-non-operating-reefer.json Outdated Show resolved Hide resolved
...ain/resources/standards/booking/messages/booking-api-2.0.0-Beta-1-regular-shipper-owned.json Outdated Show resolved Hide resolved
booking/src/main/resources/standards/booking/messages/booking-api-2.0.0-Beta-1-regular.json Outdated Show resolved Hide resolved
@preetamnpr
Copy link
Collaborator Author

Added some more remarks.

In addition, I do not see a fix for the remark I made inhttps://github.com//pull/71#pullrequestreview-1905776565

I understood now what you actually mean.. I will put these checks across different use cases.

preetamnpr
preetamnpr commented Mar 20, 2024
View reviewed changes
core/src/main/java/org/dcsa/conformance/core/check/JsonAttribute.java Outdated Show resolved Hide resolved
booking/src/main/java/org/dcsa/conformance/standards/booking/checks/BookingChecks.java Outdated Show resolved Hide resolved
booking/src/main/java/org/dcsa/conformance/standards/booking/checks/BookingChecks.java Show resolved Hide resolved
booking/src/main/java/org/dcsa/conformance/standards/booking/checks/BookingChecks.java Show resolved Hide resolved
booking/src/main/java/org/dcsa/conformance/standards/booking/checks/BookingChecks.java Outdated Show resolved Hide resolved
booking/src/main/java/org/dcsa/conformance/standards/booking/checks/BookingChecks.java Outdated Show resolved Hide resolved
booking/src/main/java/org/dcsa/conformance/standards/booking/checks/BookingChecks.java Outdated Show resolved Hide resolved
booking/src/main/java/org/dcsa/conformance/standards/booking/checks/BookingChecks.java Outdated Show resolved Hide resolved
...ng/src/main/java/org/dcsa/conformance/standards/booking/model/PersistableCarrierBooking.java Show resolved Hide resolved
@HenrikHL
Copy link
Collaborator

My issues have been fixed (also the isNonOperatingReefer - so I am good now

@preetamnpr preetamnpr merged commit 24b8eb9 into dev Mar 22, 2024
1 check passed
@nt-gt nt-gt deleted the DT-786 branch March 22, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikHL HenrikHL HenrikHL left review comments

@nt-gt nt-gt nt-gt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@preetamnpr @HenrikHL @nt-gt