Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OVS enum to free text change #35

Merged
merged 2 commits into from
Aug 15, 2023
Merged

OVS enum to free text change #35

merged 2 commits into from
Aug 15, 2023

Conversation

palatsangeetha
Copy link
Contributor

No description provided.

HenrikHL
HenrikHL reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@HenrikHL HenrikHL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume we would want to validate the content - or will we only do that via a Database persistence error?

@douradofrazer
Copy link
Collaborator

I would assume we would want to validate the content - or will we only do that via a Database persistence error?

The assumption here is that the data in the db has already been validated.
Since it's a read-only API, we do not need to have validation in place here.

@palatsangeetha palatsangeetha merged commit 070d872 into master Aug 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikHL HenrikHL HenrikHL left review comments

@douradofrazer douradofrazer douradofrazer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palatsangeetha @douradofrazer @HenrikHL