Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reformat yaml, add explicit running context, fixes #53 #54

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Jul 30, 2024

The Issue

How This PR Solves The Issue

  • Fixes some mistakes in some sections (I noticed some mistakes when I uncommented them.)
  • Adds explicit $DDEV_APPROOT/.ddev/...
  • Adds explicit running context for some sections in the comments.

Manual Testing Instructions

Check this option for easier review:

image

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording changes. Do we still want all the other changes?

install.yaml Outdated Show resolved Hide resolved
install.yaml Outdated Show resolved Hide resolved
install.yaml Outdated Show resolved Hide resolved
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine when you are happy with it.

@stasadev stasadev merged commit b6fc795 into main Jul 30, 2024
2 checks passed
@stasadev stasadev deleted the 20240730_stasadev_update_install_yaml branch July 30, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants