feat: add ddev_version_constraint (available since DDEV v1.23.4), remove #ddev-nodisplay
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
rfay
requested changes
Aug 1, 2024
install.yaml
Outdated
| # if ! ( ddev debug capabilities 2>/dev/null | grep multiple-dockerfiles >/dev/null 2>&1 ) ; then | ||
| # echo "This add-on requires DDEV v1.19.4 or higher, please upgrade." && exit 2 | ||
| # fi | ||
| # # Using #ddev-nodisplay tells ddev to be quiet about this action and not show it or its output. |
There was a problem hiding this comment.
stasadev
force-pushed
the
20240731_stasadev_ddev_version_constraint
branch
from
598e4fc
to
85ae9cd
Compare
stasadev
changed the title
ddev_version_constraint (available since DDEV v1.23.4)ddev_version_constraint (available since DDEV v1.23.4), remove #ddev-nodisplay
stasadev
changed the title
ddev_version_constraint (available since DDEV v1.23.4), remove #ddev-nodisplayddev_version_constraint (available since DDEV v1.23.4), remove #ddev-nodisplay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
ddev_version_constraintfor add-ons, remove#ddev-nodisplay, fixes #5969 ddev#6433#ddev-nodisplayddev#5969How This PR Solves The Issue
ddev_version_constraint.#ddev-nodisplay.Manual Testing Instructions
See instructions from ddev/ddev#6433
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes