-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added instructions on using multiple cores to README #39
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for stepping up to this! It's far better to use an additional docker-compose.solr_extra.yaml so that you don't have a modified and non-updateable docker-compose.solr.yaml
README.md
Outdated
@@ -70,6 +70,38 @@ services: | |||
|
|||
You can delete the "dev" core from `http://<projectname>.ddev.site:8983/solr/#/~cores/dev` by clicking "Unload". | |||
|
|||
## Multiple Solr Cores | |||
|
|||
If you would like to use more than one Solr core, you'll need to edit the file [`.ddev/docker-compose.solr.yaml`](docker-compose.solr.yaml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than editing, which orphans the add-on, use a docker-compose.solr_extra.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback - i've updated the instructions accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
The Issue
It's unclear how to use multiple solr cores.
How This PR Solves The Issue
Added steps to the README.
Manual Testing Instructions
Follow the steps in the readme.
Automated Testing Overview
I don't think any automated tests are necessary.
Related Issue Link(s)
#37