-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hierarchy group levels to table_body
in tbl_hierarchical()
#2072
Conversation
Thank you @edelarua !
I think that is perfect.
Probably don't need it right? I could go either way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great, i love it! Can we make one small change? Can you move the grouping columns to after the row_type
column? I prefer keeping all the hidden column grouped together in the beginning of the data frame.
…' into 2070_var_levels_tbl_hierarchical
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely, thank you @edelarua !
What changes are proposed in this pull request?
table_body
as returned bytbl_hierarchical()
to keep information on all hierarchy levels.Closes #2070
@ddsjoberg 2 questions:
variableXX
andvariableXX_level
? I wasn't sure since we already have avariable
column intable_body
so I left it asgroupXX
andgroupXX_level
for now.variable
where applicable?Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.md
with the changes from this pull request under the heading "# gtsummary (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
usethis::use_spell_check()
again