Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added TARGET setting to info file to support Apple II+ keypress detec… #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

riney
Copy link

@riney riney commented Aug 12, 2015

Hi! I noticed that the keypress detection didn't seem to work on the Apple II+. I added this, and a configuration switch called TARGET to the "info" file. Set it to "plus" and it'll generate my new detection code, or to "default" (or literally any other string) and it'll generate your original code. I also moved a few #DEFINEs to the top to make them easier to find. Cheers!

@deater
Copy link
Owner

deater commented Mar 11, 2016

Sorry for the long delay in responding to this.

Might a cleaner way to fix this be to not clear the keyboard strobe at all, but instead use "GET X$" to read the character which presumably should work on both a IIe and a II+?

I have to admit it's been a while since I've touched this code so I forget why I was trying to read out the value directly.

@riney
Copy link
Author

riney commented Mar 17, 2016

I want to say that GET doesn't work for certain keyboard keys (shift, open apple, etc), and that the intent was to provide a real "any key" "next slide" functionality? Honestly it's been a while myself. I have a IIc at home to test on now, I'll give it a try.

@deater
Copy link
Owner

deater commented Mar 21, 2016

It might be easier the add code that detects what kind of Apple II it is being run on and then doing the right thing.

I currently only have an Apple IIe, but maybe I can check under an emulator.

@riney
Copy link
Author

riney commented Mar 22, 2016

I have a GS, IIe, IIc, and II+, but I only have access to the IIc at the moment (just moved cross-country). I'll have a look in emulation as well. Should be easy enough to poke around in ROM and detect the machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants