utils/{gr,hgr}-utils/Makefile: Use pkg-config for compile/link flags #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to $(CC) assumed that png.h, -lpng etc. were all in the default paths used by the compiler. However, this is not the case on some systems, such as MacOS using the MacPorts package system. Add calls to pkg-config to add the appropriate paths to CFLAGS if necessary, and introduce LDFLAGS for linker library paths. This assumes that pkg-config is available; it usually is (particularly on systems using GCC), but further work may be required if this is required to run on systems where it's not. This also assumes Gnu Make; again further work may be required if this needs to be made compatible with Berkeley Make. This has been tested on Debian 11 and on MacOS 10.14.6 with MacPorts 2.8.1
|
Just checking in to see if this can get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to $(CC) assumed that png.h, -lpng etc. were all in the default paths used by the compiler. However, this is not the case on some systems, such as MacOS using the MacPorts package system.
Add calls to pkg-config to add the appropriate paths to CFLAGS if necessary, and introduce LDFLAGS for linker library paths.
This assumes that pkg-config is available; it usually is (particularly on systems using GCC), but further work may be required if this is required to run on systems where it's not.
This also assumes Gnu Make; again further work may be required if this needs to be made compatible with Berkeley Make.
This has been tested on Debian 11 and on MacOS 10.14.6 with MacPorts 2.8.1