Fix SSH_HOSTS environment variable to actually work #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kapetan @christianklotz Tested and works (and is needed to be functional) |
|
Any changes of merging the changes? |
|
+1 |
Wojcirej
added a commit
to Wojcirej/ssh-private-key-buildpack
that referenced
this pull request
Mar 21, 2024
This is fix provided in the following PR: debitoor#9
Wojcirej
added a commit
to Wojcirej/ssh-private-key-buildpack
that referenced
this pull request
Mar 21, 2024
This is fix provided in the following PR: debitoor#9 Apparently Heroku environment variables for the application are not exposed to buildpacks, instead $ENV_DIR directory contains files for the environment variables application uses. This fixes that actually setting SSH_HOSTS works with this buildpack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently Heroku environment variables for the application are not exposed to buildpacks, instead $ENV_DIR directory contains files for the environment variables application uses. This fixes that actually setting SSH_HOSTS works with this buildpack.