Skip to content

Commit

Permalink
Enable fingerprint by default for all repos (#259)
Browse files Browse the repository at this point in the history
  • Loading branch information
sweoggy authored Sep 11, 2024
1 parent 7fd84ca commit a9920ff
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
2 changes: 1 addition & 1 deletion UPGRADE-2.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Changed behaviours
- Changes default strictness of resolve command to 1 (Exit with code 1 if all files failed to resolve, otherwise exit with code 0 instead of always exiting with code 0)
- File Fingerprint analysis is on by default for all repositories which starts with the letters "A-C". This range will be increased in future minor/patch releases.
- File Fingerprint analysis is on by default for all repositories which starts with the letters "A-C" (starting from v2.0.9 it is default for all repos). This range will be increased in future minor/patch releases.
- Added inclusion option to commands to force include patterns which are by default ignored by the CLI
- Refactored how exclusion works for fingerprinting to align it with the rest of the CLI, this includes a breaking change for windows where Unix path separators must be used in patterns.

Expand Down
9 changes: 0 additions & 9 deletions internal/cmd/scan/scan.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,6 @@ If the given path contains a git repository all flags but "integration" will be
PreRun: func(cmd *cobra.Command, _ []string) {
_ = viper.BindPFlags(cmd.Flags())
},
RunE: func(cmd *cobra.Command, args []string) error {
if len(viper.GetString(RepositoryFlag)) > 0 {
if strings.ToLower(viper.GetString(RepositoryFlag))[0] < 't' && !cmd.Flags().Changed(NoFingerprintFlag) {
viper.Set(NoFingerprintFlag, false)
} // Temporary addition for rolling release of fingerprinting enabled by default
}

return RunE(&scanner)(cmd, args)
},
}
cmd.Flags().StringVarP(&repositoryName, RepositoryFlag, "r", "", "repository name")
cmd.Flags().StringVarP(&commitName, CommitFlag, "c", "", "commit hash")
Expand Down

0 comments on commit a9920ff

Please sign in to comment.