Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytics tags #167

Merged
merged 7 commits into from
Dec 6, 2019
Merged

Add analytics tags #167

merged 7 commits into from
Dec 6, 2019

Conversation

castrolem
Copy link
Contributor

@castrolem castrolem commented Dec 5, 2019

What:

  • Add Google and Amplitude init scripts.
  • Set amplitude user ID to our users' ids.

#121 and #122

Why:
To track them all

How:
By adding the script tags for both services and env variables to set the correct ones on our deployment systems.

@castrolem castrolem self-assigned this Dec 5, 2019
app/views/static_pages/home.html.erb Outdated Show resolved Hide resolved
Copy link
Contributor

@orlando orlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orlando orlando merged commit adfee39 into master Dec 6, 2019
@orlando orlando deleted the feat/add-analytics branch December 6, 2019 16:44
@debt-bot
Copy link
Member

debt-bot commented Dec 6, 2019

🎉 This PR is included in version 1.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants