Added min-height for .section class to prevent blank space below footer #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👷 Deploy request for gatsby-starter-netlify-cms-ci pending review. 🔨 Explore the source changes: 3d2015e |
ghost
mentioned this pull request
ghost
closed this
ghost
reopened this
ghost
closed this
|
@enzom-uy I noticed your commits on this, are you the one who opened this PR? If you happened to, you might want to try again. For some reason, it looks like something went a bit haywire with GitHub on this. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adresses issue #789. In certain cases the footer had a white space underneath, this usually happens because there is not enough content to push it all the way down, or because the height of the content is too small. The only thing I did was to add a minimum height completely insignificat for the layout of the website, but that pushes the footer to the bottom.
What kind of change does this PR introduce?
Adds a min-height:50.6vh to the .section classes, this does not generate any conflict in any section of the page, there's no layout change, and is large enough to push the footer down.
Does this PR introduce a breaking change?
No, it only makes the footer always be at the bottom of the page, without a white space underneath.
What needs to be documented once your changes are merged?
Nothing :).