Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Figure out how to enforce AS and NMP properties on DT filters without affecting the gain #31

Open
eid-not-die opened this issue Dec 18, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@eid-not-die
Copy link

eid-not-die commented Dec 18, 2024

This issue concerns the method _identify_uncertainty_upper_bound as it appears in the module src/dkpy/uncertainty_bound.py in the branch feature/22-add-equivalent-of-matlabs-ucover as of the time of this post.

As it stands, the method does not handle discrete-time (DT) models. However, most of the code present in this version is ready to handle them. The only exception is the portion enforcing the properties of asymptotic stability (AS) and nonminimum phase (NMP) on the final filter. This is easy to handle in the continuous-time (CT) case.

Is it possible to make a DT linear filter AS and NMP without affecting its gain?

A (possibly too obvious) solution would be to

  • convert it to CT,
  • enforce AS and NMP properties in CT, and
  • convert it back to DT.

Would this work? Which discretization method would be appropriate?

@eid-not-die eid-not-die added the enhancement New feature or request label Dec 18, 2024
@eid-not-die eid-not-die assigned sdahdah and eid-not-die and unassigned sdahdah Dec 18, 2024
@sdahdah
Copy link
Member

sdahdah commented Dec 18, 2024

If you want, you can focus on just the CT case for now since D-K iteration is really only practical in CT. Maybe someone will want to use this library for uncertainty characterization in the DT case eventually, so it would be nice to support it if we can at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants